Extract DatabaseItem.refresh method to DatabaseManager#2450
Merged
Conversation
This will allow us to implement specific behavior on the `DatabaseItemImpl` which is not available on the `DatabaseItem`. This will allow us to make the surface area of the `DatabaseItem` smaller.
This moves the `refresh` method from `DatabaseItem` to `DatabaseManager` and makes it private. This makes the `DatabaseItem` interface smaller and more focused and ensures that `refresh` cannot be called from outside of the `DatabaseManager`.
koesie10
force-pushed
the
koesie10/move-database-item-refresh
branch
from
809ed71 to
09fc0f3
Compare
charisk
approved these changes
May 25, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Nice bit of refactoring there! Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the
DatabaseItem.refreshmethod out of theDatabaseIteminterface and moves it to theDatabaseManageritself. This makes theDatabaseIteminterface smaller and ensures that therefreshmethod is not called outside of theDatabaseManager.It's easiest to review this commit-by-commit.
Checklist
ready-for-doc-reviewlabel there.